Enhancement/9344 acrsubtlenotification component #9547
+404
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crsubtlenotification-component.
zutigrm
commented
Oct 22, 2024
| @@ -124,7 +124,7 @@ $c-yellow-y-900: #1f1400; | |||
| $c-yellow-y-1000: #000; | |||
| $c-violet-v-0: #fff; | |||
| $c-violet-v-10: #fbf9ff; | |||
| $c-violet-v-50: #dbc5ff; | |||
| $c-violet-v-50: #e3d1ff; | |||
There was a problem hiding this comment.
This color token has a new value in Figma, and since this variable was not used anywhere so far, I updated it's value instead of creating a duplicate variable with different value
|
Size Change: +701 B (+0.04%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Build files for 7fc905d are ready:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
ACRSubtleNotifciationSubtle Notification Banner Component & Include in KMW Settings Area for Users Who Have Not Yet Set Up KMW, or Users With Manual KMW Setup #9344Relevant technical choices
Approach has been simplified a bit from what was originally written in IB. Notification could be included in one place only
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist